Skip to content

Feature: Backend for Correlation #1052

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Dec 31, 2024
Merged

Feature: Backend for Correlation #1052

merged 7 commits into from
Dec 31, 2024

Conversation

parmesant
Copy link
Contributor

Fixes #XXXX.

Description

This PR has:

  • been tested to ensure log ingestion and log query works.
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added documentation for new or modified features or behaviors.

@coveralls
Copy link

coveralls commented Dec 24, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 12555994595

Details

  • 0 of 332 (0.0%) changed or added relevant lines in 10 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.2%) to 11.629%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/handlers/http/query.rs 0 1 0.0%
src/storage/localfs.rs 0 2 0.0%
src/cli.rs 0 3 0.0%
src/handlers/http/modal/query_server.rs 0 4 0.0%
src/rbac/role.rs 0 12 0.0%
src/storage/object_storage.rs 0 18 0.0%
src/correlation/correlation_utils.rs 0 23 0.0%
src/handlers/http/modal/server.rs 0 38 0.0%
src/handlers/http/correlation.rs 0 69 0.0%
src/correlation/mod.rs 0 162 0.0%
Totals Coverage Status
Change from base Build 12511730436: -0.2%
Covered Lines: 2152
Relevant Lines: 18506
💛 - Coveralls

@parmesant parmesant marked this pull request as ready for review December 26, 2024 08:21
nikhilsinhaparseable
nikhilsinhaparseable approved these changes Dec 31, 2024
View reviewed changes
Copy link
Contributor

@nikhilsinhaparseable nikhilsinhaparseable left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to merge

@nitisht nitisht merged commit 794c8f1 into parseablehq:main Dec 31, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikhilsinhaparseable nikhilsinhaparseable nikhilsinhaparseable approved these changes

Assignees
No one assigned
Labels
for next release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@parmesant @coveralls @nikhilsinhaparseable @nitisht